Magick++ STL.h

[dlemstra]

Is it possible to add the following methods to STL.h:

MagickCore::CombineImages
MagickCore::EvaluateImages
MagickCore::MergeImageLayers
MagickCore::OptimizeImageLayers
MagickCore::OptimizePlusImageLayers
MagickCore::SeparateImages

And modify linkImages? The current code results in a false positive from Code Analysis.

Before:

Code: Select all

current->next     = 0;

if ( previous != 0)
  previous->next = current;

current->scene=scene;
++scene;

After:

Code: Select all

current->next     = 0;
current->scene    = scene++;

if ( previous != 0)
  previous->next = current;

[magick]

Give us a week or so. Look for the patches in ImageMagick 6.8.6-4 beta.

[dlemstra]

Thanks for the quick response, I can supply you with a patch for the methods if you are interested.

[magick]

Thanks for the quick response, I can supply you with a patch for the methods if you are interested.

Of course. Post a URL to your patches so we can download them and apply them to the ImageMagick Subversion trunk. Thanks.

[dlemstra]

Is there an e-mail address e.g., 'patches at imagemagick.org' I can mail a patch to?

[magick]

Yes, use patches at imagemagick dot org.

[magick]

A few of the patches in Geometry.{cpp,h} did not stick. Download the latest and send us the differences from your source modules. Thanks.

[dlemstra]

I already mailed a second set of patches (with revision 12637).

Is the public repository copied from an internal repository? When i checked the logs at http://trac.imagemagick.org/log/ it said the changes where made 8 hours ago. But when I checked the logs 4 hours earlier I could not see those changes. Or is that a because of the timezone difference with Europe?

[magick]

trac.imagemagick.org can be up to 24 hours stale. The authoritative Subversion trunk is @ subversion.imagemagick.org.

[dlemstra]

I figured out what went wrong. I was using the url 'https://www.imagemagick.org/subversion' instead of 'https://subversion.imagemagick.org/subversion'. I found that url here: 'http://www.imagemagick.org/script/subversion.php'. I will email another set of patches.

[magick]

Patches applied. Thanks.