ImageMagick-6.8.8-10 configure.ac has useless mupdf check

Post any defects you find in the released or beta versions of the ImageMagick software here. Include the ImageMagick version, OS, and any command-line required to reproduce the problem. Got a patch for a bug? Post it here.
Post Reply
ssuominengentoo
Posts: 5
Joined: 2014-04-06T05:01:28-07:00
Authentication code: 6789

ImageMagick-6.8.8-10 configure.ac has useless mupdf check

Post by ssuominengentoo »

The configure.ac checks for mupdf libraries and headers, but nothing in ImageMagick is actually using them
No mupdf libraries used, no #include's either

Basically you can trick the build system by:

export ac_cv_lib_mupdf_fz_new_context=yes
export ac_cv_header_mupdf_fitz_h=yes
./configure --with-mupdf

and the result is exactly same as with --without-mupdf

It looks like if someone pushed changes to only configure.ac, and forgot to commit rest of the patch that actually adds anykind of mupdf support
ssuominengentoo
Posts: 5
Joined: 2014-04-06T05:01:28-07:00
Authentication code: 6789

Re: ImageMagick-6.8.8-10 configure.ac has useless mupdf chec

Post by ssuominengentoo »

Not to mention, if mupdf libs and headers are intended to be used in the future, there is mupdf.pc pkg-config file that should be queried, rather than using the old-styled AC_CHECK_* for them
User avatar
magick
Site Admin
Posts: 11064
Joined: 2003-05-31T11:32:55-07:00

Re: ImageMagick-6.8.8-10 configure.ac has useless mupdf chec

Post by magick »

Patch applied to Subversion trunk. Thanks.
Post Reply