Backport of security bug and problem

[broucaries]

Hi,

http://trac.imagemagick.org/changeset/17297 is problematic.

Try convert rose: rose.xpm
then display rose.xpm

Have you an idea ?

Bastien

[magick]

We reverted this patch in Subversion until we can investigate and come up with a proper patch. Thanks for alerting us to the problem.

[broucaries]

The original reporter propose a new patch:

https://bugs.debian.org/773980

What do you think ?

Bastien

[magick]

That patch works along with a slight mod to CopyXPMColor():

Code: Select all

static size_t CopyXPMColor(char *destination,const char *source,size_t length)
{
  register const char
    *p;

  p=source;
  while (length-- && (*p != '\0'))
    *destination++=(*p++);
  if (length != 0)
    *destination='\0';
  return((size_t) (p-source));
}