A strategy to compile wand/deprecated.c

[yecril71pl]

Problem: wand/deprecated.c produces noise in build. It implements functions that are deprecated, therefore the noise is unavoidable, unless …
in deprecated.c:

Code: Select all

#define MAGICK_WAND_DEPRECATED

in deprecated.h:

Code: Select all

#ifndef MAGICK_WAND_DEPRECATED 
#define MAGICK_WAND_DEPRECATED magick_attribute((deprecated))
#endif

and replace /magick_attribute((deprecated))/ with MAGICK_WAND_DEPRECATED afterwards
Clean up at the end:

Code: Select all

#undef MAGICK_WAND_DEPRECATED

What do you think?

[anthony]

Why?

Most programs generate compile time noise. It is usually the developer that worries about such noise.

[yecril71pl]

Unless you are willing to fix this bug in predictable time, I am a developer now:

convert: unable to open image `+1570': /usr▒²©Ú64/Image`²©Úÿ @ error/blob.c/OpenBlob/2489.
convert: unable to open image `SAD': /usr▒²©Ú64/Image`²©Úÿ @ error/blob.c/OpenBlob/2489.

(the message emitted should make sense)

I am going to fix the warnings first, because last time I spent two days debugging it was because I ignored the warnings. And it is better to fix the warnings once and for all than to have to sift through them each time in hope of finding something relevant. Also, I am actually unable to debug the library code because it is intensively optimised (which is a good thing, of course).