Results of running a code analyzer on ImageMagick

Questions and postings pertaining to the development of ImageMagick, feature enhancements, and ImageMagick internals. ImageMagick source code and algorithms are discussed here. Usage questions which are too arcane for the normal user list should also be posted here.
Post Reply
naoliv
Posts: 110
Joined: 2007-12-10T18:54:27-07:00
Location: Brazil

Results of running a code analyzer on ImageMagick

Post by naoliv »

Hi!

I was running a C/C++ code analyzer (cppcheck - http://cppcheck.wiki.sourceforge.net/) against ImageMagick, and I've got these results (none of them are errors):
http://people.debian.org/~naoliv/misc/i ... pcheck.txt

Note that there might be false positives or wrong line numbers. For example:

Code: Select all

[./coders/gif.c:947]: Variable 'dispose' is assigned a value that is never used
Actually it's line 1027.

Tested against latest version from SVN (revision 13730)

Thank you!
User avatar
magick
Site Admin
Posts: 11064
Joined: 2003-05-31T11:32:55-07:00

Re: Results of running a code analyzer on ImageMagick

Post by magick »

We'll review the report and see if any of the problems reported require attention. We noticed the report has an excessive number of false positives, mostly "Variable is assigned a value that is never used."
User avatar
magick
Site Admin
Posts: 11064
Joined: 2003-05-31T11:32:55-07:00

Re: Results of running a code analyzer on ImageMagick

Post by magick »

Glad we could help debug your software. A code checker is a useful tool and as soon as the false positive problem is fixed we envision using your software to verify ImageMagick before each release is approved. We do something similar with runtime checks (e.g. valgrind). Thanks.
Post Reply