Makefile.am/in bug in src package - drd clause
Posted: 2010-08-05T08:43:58-07:00
I don't know when this started, but it's present in at least 6.6.2-10 and later. Platform is FreeBSD 7.0-RELEASE
In the distributed Makefile.am:
In the distributed Makefile.in:
This shouldn't be duplicated, and the first group (lines 205-208, 11193-11196) is invalid because of bad indentation. This causes `configure` to generate a bad Makefile, which fails to `make`:
Removing the bad and duplicated drd block from the Makefile results in `make` building properly.
In the distributed Makefile.am:
Code: Select all
204 # drd: valgrind's newer thread error detector
205 drd:
206 $(MAKE) MEMCHECK='valgrind --tool=drd --check-stack-var=yes --var-info=yes \
207 --quiet $(VALGRIND_EXTRA_OPTS)' check
208
209 # drd: valgrind's newer thread error detector
210 drd:
211 $(MAKE) MEMCHECK='valgrind --tool=drd --check-stack-var=yes --var-info=yes \
212 --quiet $(VALGRIND_EXTRA_OPTS)' check
213
Code: Select all
11192 # drd: valgrind's newer thread error detector
11193 drd:
11194 $(MAKE) MEMCHECK='valgrind --tool=drd --check-stack-var=yes --var-info=yes \
11195 --quiet $(VALGRIND_EXTRA_OPTS)' check
11196
11197 # drd: valgrind's newer thread error detector
11198 drd:
11199 $(MAKE) MEMCHECK='valgrind --tool=drd --check-stack-var=yes --var-info=yes \
11200 --quiet $(VALGRIND_EXTRA_OPTS)' check
11201
Code: Select all
"Makefile", line 11195: Need an operator
make: fatal errors encountered -- cannot continue