cosmetic corrections to ImageMagick.spec.in

Questions and postings pertaining to the development of ImageMagick, feature enhancements, and ImageMagick internals. ImageMagick source code and algorithms are discussed here. Usage questions which are too arcane for the normal user list should also be posted here.
Post Reply
User avatar
yecril71pl
Posts: 81
Joined: 2011-02-08T11:06:09-07:00
Authentication code: 8675308
Location: Warsaw, Poland
Contact:

cosmetic corrections to ImageMagick.spec.in

Post by yecril71pl »

Corrections:
  1. macros in RPM comments are not allowed
  2. changelog text must not begin with *

Code: Select all

diff -aur ImageMagick-6.6.7-7/ImageMagick.spec.in ImageMagick-6.6.7-8/ImageMagick.spec.in
--- ImageMagick-6.6.7-7/ImageMagick.spec.in    2010-06-13 21:04:44.000000000 +0200
+++ ImageMagick-6.6.7-8/ImageMagick.spec.in    2011-02-20 18:55:27.888401391 +0100
@@ -114,7 +114,7 @@
 iconv -f ISO-8859-1 -t UTF-8 README.txt > README.txt.tmp
 touch -r README.txt README.txt.tmp
 mv README.txt.tmp README.txt
-# for %doc
+# for %%doc
 mkdir Magick++/examples
 cp -p Magick++/demo/*.cpp Magick++/demo/*.miff Magick++/examples
 
@@ -278,4 +278,4 @@
 
 %changelog
 * Sun May 01 2005 Cristy <cristy@mystic.es.dupont.com> 1.0-0
-*  Port of Redhat's RPM script to support ImageMagick.
+-  Port of Redhat's RPM script to support ImageMagick.
User avatar
magick
Site Admin
Posts: 11064
Joined: 2003-05-31T11:32:55-07:00

Re: cosmetic corrections to ImageMagick.spec.in

Post by magick »

Thanks, we'll have your patch in ImageMagick 6.6.7-9 Beta by sometime tomorrow.
User avatar
yecril71pl
Posts: 81
Joined: 2011-02-08T11:06:09-07:00
Authentication code: 8675308
Location: Warsaw, Poland
Contact:

Re: cosmetic corrections to ImageMagick.spec.in

Post by yecril71pl »

ImageMagick.x86_64: E: summary-too-long (Badness: 200)
C ImageMagick is a software suite to create, edit, and compose bitmap images.
It can read, convert and write images in a variety of formats (about 200)
including GIF, JPEG, JPEG-2000, PNG, PDF, PhotoCD, TIFF, and DPX.
Use ImageMagick to translate, flip, mirror, rotate, scale, shear and transform images,
adjust image colors, apply various special effects,
The "Summary:" must not exceed 79 characters.

ImageMagick.x86_64: W: summary-ended-with-dot (Badness: 89)
ImageMagick.x86_64: W: name-repeated-in-summary
Fix ImageMagick.spec:

Code: Select all

Summary:        A software suite to create, edit, and compose bitmap images 
Moreover, the paragraphs 3 and 4 of the %description are repeated, and the text would read better broken.

Code: Select all

%description
ImageMagick is a software suite to create, edit, and compose bitmap images. 
It can read, convert and write images in a variety of formats (about 100) 
including DPX, GIF, JPEG, JPEG-2000, PDF, PhotoCD, PNG, Postscript, SVG, and TIFF. 
Use ImageMagick 
  * to translate, flip, mirror, rotate, scale, shear and transform images, 
  * adjust image colors, apply various special effects, 
  * or draw text, lines, polygons, ellipses and Bézier curves.

The functionality of ImageMagick is typically utilized from the command line 
or you can use the features from programs written in your favorite programming language. 
Choose from these interfaces: 
  * G2F (Ada), 
  * MagickCore (C), 
  * MagickWand (C), 
  * ChMagick (Ch), 
  * Magick++ (C++), 
  * JMagick (Java), 
  * L-Magick (Lisp), 
  * nMagick (Neko/haXe), 
  * PascalMagick (Pascal), 
  * PerlMagick (Perl), 
  * MagickWand for PHP (PHP), 
  * PythonMagick (Python), 
  * RMagick (Ruby), 
  * or TclMagick (Tcl/TK). 
With a language interface, 
use ImageMagick to modify or create images automagically and dynamically.

ImageMagick is free software 
delivered as a ready-to-run binary distribution or as source code 
that you may freely use, copy, modify, and distribute in both open and proprietary applications. 
It is distributed under an Apache 2.0-style license, approved by the OSI.

The ImageMagick development process ensures a stable API and ABI. 
Before each ImageMagick release, we perform a comprehensive security assessment 
that includes memory and thread error detection to help prevent exploits.


ImageMagick-perl.x86_64: W: no-dependency-on perl-base

Code: Select all

%package -n perl-%{name}
Summary: ImageMagick perl bindings
Requires: perl-base = %{perl_version}
Note: the process of generating an RPM is not documented; it is built on "make snapshot". It seems unsupported and internal to vendor, as it places the result in /var/ftp, not in /usr/src. To summarize:
  • ImageMagick.spec is not distributed with the tarball
  • ImageMagick.spec is created by configure
  • if you use rpmbuild, ImageMagick.spec is not installed anywhere and ultimately dropped,
  • if you make snapshot, ImageMagick.spec is embedded into the SRPM, but installed in a vendor-specific absolute location (not in $RPMBUILDROOT)
The bottom line is, if you want to use the configured ImageMagick.spec, you have to stop the build after configuring and pick it from the build tree by hand.
Post Reply