[serious] Copyright header are missing for three m4 files

[broucaries]

Hi,

You have removed when copying two copyright headers:
* m4/magick_check_pthread_lib.m4 should have keep original header [1]. Note I believe this macro should be removed and replaced by modern http://www.gnu.org/software/autoconf-ar ... hread.html
* m4/magick_func_mmap_fileio.m4 should have keep original header from autoconf. I could not find the original file and the goal of this macro. Could you help here ?
* m4/framework.m4 no author no copyright. I could not find this file. It seems that you write this test If you put under all permissive license and document the purpose I could incorpore in autoconf archive and remove the burden of maintaining this file.

Bastien




[1] Copyright: Steven G. Johnson <stevenj@alum.mit.edu>
GPLWithACException
This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation. As a special exception, the respective Autoconf Macro's copyright owner gives unlimited permission to copy, distribute and modify the configure scripts that are the output of Autoconf when processing the Macro. You need not follow the terms of the GNU General Public License when using or distributing such scripts

[magick]

* m4/magick_check_pthread_lib.m4 should have keep original header [1]. Note I believe this macro should be removed and replaced by modern http://www.gnu.org/software/autoconf-ar ... hread.html

Fixed.

* m4/magick_func_mmap_fileio.m4 should have keep original header from autoconf. I could not find the original file and the goal of this macro. Could you help here ?

Clueless. This was contributed by a user 15 years ago and we have no idea of its origin.

* m4/framework.m4 no author no copyright. I could not find this file. It seems that you write this test If you put under all permissive license and document the purpose I could incorpore in autoconf archive and remove the burden of maintaining this file.

See http://svn.saurik.com/repos/cycript/trunk/framework.m4. The project includes the GNU Lesser license. Is the Lesser license incompatible with Apache 2.0 license? If so, we'll need to remove framework.m4 from the ImageMagick project.

[broucaries]

* m4/magick_check_pthread_lib.m4 should have keep original header [1]. Note I believe this macro should be removed and replaced by modern http://www.gnu.org/software/autoconf-ar ... hread.html

Fixed.

Thanks

[qutote]

* m4/magick_func_mmap_fileio.m4 should have keep original header from autoconf. I could not find the original file and the goal of this macro. Could you help here ?

Clueless. This was contributed by a user 15 years ago and we have no idea of its origin.
[/quote]

AC_FUNC_MMAP in recent autoconf do the same thing and is better from an implementation point of view and tracking copyright.

* m4/framework.m4 no author no copyright. I could not find this file. It seems that you write this test If you put under all permissive license and document the purpose I could incorpore in autoconf archive and remove the burden of maintaining this file.

See http://svn.saurik.com/repos/cycript/trunk/framework.m4. The project includes the GNU Lesser license. Is the Lesser license incompatible with Apache 2.0 license? If so, we'll need to remove framework.m4 from the ImageMagick project.[/quote]

It is compatible but I believe you should add LGPL header to the m4 file and source. I believe we could rewrite it using other macro from autoconf archive but it is not serious

Hi,

You have removed when copying two copyright headers:
* m4/magick_check_pthread_lib.m4 should have keep original header [1]. Note I believe this macro should be removed and replaced by modern http://www.gnu.org/software/autoconf-ar ... hread.html
* m4/magick_func_mmap_fileio.m4 should have keep original header from autoconf. I could not find the original file and the goal of this macro. Could you help here ?
* m4/framework.m4 no author no copyright. I could not find this file. It seems that you write this test If you put under all permissive license and document the purpose I could incorpore in autoconf archive and remove the burden of maintaining this file.

Bastien




[1] Copyright: Steven G. Johnson <stevenj@alum.mit.edu>
GPLWithACException
This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation. As a special exception, the respective Autoconf Macro's copyright owner gives unlimited permission to copy, distribute and modify the configure scripts that are the output of Autoconf when processing the Macro. You need not follow the terms of the GNU General Public License when using or distributing such scripts

[magick]

Problems resolved in the Subversion trunk. Thanks.

[broucaries]

I have a patch send to usual address to remove one of the m4 file.

Bastien