std::string attribute(const std::string name_ ) signature

Post any defects you find in the released or beta versions of the ImageMagick software here. Include the ImageMagick version, OS, and any command-line required to reproduce the problem. Got a patch for a bug? Post it here.
Post Reply
wizard29
Posts: 58
Joined: 2014-03-21T00:40:16-07:00
Authentication code: 6789
Location: Russia, Saint Petersburg
Contact:

std::string attribute(const std::string name_ ) signature

Post by wizard29 »

Hi.

The std::string Magick::Image::attribute(const std::string name_ ) looks like a mistake.
I think std::string Magick::Image::attribute(const std::string& name_ ) const will be correct if no internal data is changed inside the function.
User avatar
dlemstra
Posts: 1570
Joined: 2013-05-04T15:28:54-07:00
Authentication code: 6789
Contact:

Re: std::string attribute(const std::string name_ ) signature

Post by dlemstra »

Thank you for reporting this, I have also added const to the following methods:

- bool antiAlias(void)
- size_t colorMapSize(void)
- size_t totalColors(void)
- std::string artifact(const std::string &name_)
- ImageMoments moments(void)
- Image separate(const ChannelType channel_)
- Image uniqueColors(void)

Please let me know if you think I missed another one.
.NET + ImageMagick = Magick.NET https://github.com/dlemstra/Magick.NET, @MagickNET, Donate
Post Reply